Re: [PATCH net-next v3 1/4] stmmac: loongson: Pass correct arg to PCI function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2/24/25 9:53 PM, Philipp Stanner 写道:
pcim_iomap_regions() should receive the driver's name as its third
parameter, not the PCI device's name.

Define the driver name with a macro and use it at the appropriate
places, including pcim_iomap_regions().

Cc: stable@xxxxxxxxxxxxxxx # v5.14+
Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>

Reviewed-by: Yanteng Si <si.yanteng@xxxxxxxxx>


Thanks,

Yanteng

---
  drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index bfe6e2d631bd..73a6715a93e6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -11,6 +11,8 @@
  #include "dwmac_dma.h"
  #include "dwmac1000.h"
+#define DRIVER_NAME "dwmac-loongson-pci"
+
  /* Normal Loongson Tx Summary */
  #define DMA_INTR_ENA_NIE_TX_LOONGSON	0x00040000
  /* Normal Loongson Rx Summary */
@@ -555,7 +557,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
  	for (i = 0; i < PCI_STD_NUM_BARS; i++) {
  		if (pci_resource_len(pdev, i) == 0)
  			continue;
-		ret = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));
+		ret = pcim_iomap_regions(pdev, BIT(0), DRIVER_NAME);
  		if (ret)
  			goto err_disable_device;
  		break;
@@ -673,7 +675,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = {
  MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);
static struct pci_driver loongson_dwmac_driver = {
-	.name = "dwmac-loongson-pci",
+	.name = DRIVER_NAME,
  	.id_table = loongson_dwmac_id_table,
  	.probe = loongson_dwmac_probe,
  	.remove = loongson_dwmac_remove,




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux