Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 24, 2025 at 06:15:27PM +0800, Haoxiang Li wrote:
> Variable allocated by charlcd_alloc() should be released
> by charlcd_free(). The following patch changed kfree() to
> charlcd_free() to fix an API misuse.

> Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> Cc: stable@xxxxxxxxxxxxxxx

Okay, looking closer to the current state of affairs, the change
does not fix anything actually. OTOH it's correct semantically and
allows to do any further development in charlcd_alloc(), if any.

That said, if Geert is okay with it, I would like to apply but without
Fixes/Cc: stable@ tags.

P.S.
The very similar needs to be applied to panel.c, but I already have
a patch for that locally, thanks to this thread.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux