On Wed, 19 Feb 2025 09:28:06 +0100 Greg Kroah-Hartman wrote: > 6.13-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Jakub Kicinski <kuba@xxxxxxxxxx> > > [ Upstream commit 5fda3f35349b6b7f22f5f5095a3821261d515075 ] > > Protect writes to netdev->reg_state with netdev_lock(). > >From now on holding netdev_lock() is sufficient to prevent > the net_device from getting unregistered, so code which > wants to hold just a single netdev around no longer needs > to hold rtnl_lock. > > We do not protect the NETREG_UNREGISTERED -> NETREG_RELEASED > transition. We'd need to move mutex_destroy(netdev->lock) > to .release, but the real reason is that trying to stop > the unregistration process mid-way would be unsafe / crazy. > Taking references on such devices is not safe, either. > So the intended semantics are to lock REGISTERED devices. > > Reviewed-by: Joe Damato <jdamato@xxxxxxxxxx> > Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx> > Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx> > Link: https://patch.msgid.link/20250115035319.559603-3-kuba@xxxxxxxxxx > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > Stable-dep-of: 011b03359038 ("Revert "net: skb: introduce and use a single page frag cache"") > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> Please drop from all branches
