Re: [PATCH 1/2] dm-integrity: Avoid divide by zero in table status in Inline mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sun, 16 Feb 2025, Milan Broz wrote:

> In Inline mode, the journal is unused, and journal_sectors is zero.
> 
> Calculating the journal watermark requires dividing by journal_sectors,
> which should be done only if the journal is configured.
> 
> Otherwise, a simple table query (dmsetup table) can cause OOPS.
> 
> This bug did not show on some systems, perhaps only due to
> compiler optimization.
> 
> On my 32-bit testing machine, this reliably crashes with the following:
> 
>  : Oops: divide error: 0000 [#1] PREEMPT SMP
>  : CPU: 0 UID: 0 PID: 2450 Comm: dmsetup Not tainted 6.14.0-rc2+ #959
>  : EIP: dm_integrity_status+0x2f8/0xab0 [dm_integrity]
>  ...
> 
> Signed-off-by: Milan Broz <gmazyland@xxxxxxxxx>
> Fixes: fb0987682c62 ("dm-integrity: introduce the Inline mode")
> Cc: stable@xxxxxxxxxxxxxxx # 6.11+

Both patches applied, thanks.

Mikulas





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux