This is a note to let you know that I've just added the patch titled
mm/gup: Replace ACCESS_ONCE with READ_ONCE
to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mm-gup-replace-access_once-with-read_once.patch
and it can be found in the queue-3.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 38c5ce936a0862a6ce2c8d1c72689a3aba301425 Mon Sep 17 00:00:00 2001
From: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Date: Tue, 6 Jan 2015 22:54:46 +0100
Subject: mm/gup: Replace ACCESS_ONCE with READ_ONCE
From: Christian Borntraeger <borntraeger@xxxxxxxxxx>
commit 38c5ce936a0862a6ce2c8d1c72689a3aba301425 upstream.
ACCESS_ONCE does not work reliably on non-scalar types. For
example gcc 4.6 and 4.7 might remove the volatile tag for such
accesses during the SRA (scalar replacement of aggregates) step
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
Fixup gup_pmd_range.
Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
mm/gup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -926,7 +926,7 @@ static int gup_pmd_range(pud_t pud, unsi
pmdp = pmd_offset(&pud, addr);
do {
- pmd_t pmd = ACCESS_ONCE(*pmdp);
+ pmd_t pmd = READ_ONCE(*pmdp);
next = pmd_addr_end(addr, end);
if (pmd_none(pmd) || pmd_trans_splitting(pmd))
Patches currently in stable-queue which might be from borntraeger@xxxxxxxxxx are
queue-3.19/x86-spinlocks-paravirt-fix-memory-corruption-on-unlock.patch
queue-3.19/ppc-hugetlbfs-replace-access_once-with-read_once.patch
queue-3.19/mm-gup-replace-access_once-with-read_once.patch
queue-3.19/kernel-make-read_once-valid-on-const-arguments.patch
queue-3.19/kvm-s390-base-hrtimer-on-a-monotonic-clock.patch
queue-3.19/kernel-tighten-rules-for-access-once.patch
queue-3.19/next-sh-fix-compile-error.patch
queue-3.19/kvm-s390-floating-irqs-fix-user-triggerable-endless-loop.patch
queue-3.19/kvm-s390-forward-hrtimer-if-guest-ckc-not-pending-yet.patch
queue-3.19/ppc-kvm-replace-access_once-with-read_once.patch
queue-3.19/kernel-fix-sparse-warning-for-access_once.patch
queue-3.19/kvm-s390-avoid-memory-leaks-if-__inject_vm-fails.patch
queue-3.19/x86-xen-p2m-replace-access_once-with-read_once.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html