On Fri, Feb 14, 2025 at 02:35:34PM +0100, Greg KH wrote: > On Fri, Feb 07, 2025 at 11:27:04AM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > commit d00ffba4adacd0d4d905f6e64bd8cd87011f5711 upstream > > There is no such commit upstream :( > > And maybe because of this, it turns out this commit breaks the build, so > I'll be dropping it now. Heh, I originally ported this patch when it was in my dev tree, then later fixed something in the dev branch and forgot to update the lts branch. Then all those quota fixes got delayed for a month because the upstream maintainer was on vacation and didn't push anything, and I forgot to ever get back to this, and checkpatch didn't notice because it doesn't validate commit ids that link to another repo. Soooo here I go updating my bespoke checkpatch for a third day in a row, and will resubmit this patch soon. Q: Does everyone else already have Really Good maintainer scripts and I am the grossly ignorant one? Or is scripts/checkpatch.pl really the only thing available? Because it whines about things that nobody in the xfs community really care about (minor style problems), and misses things that we really /do/ care about (correct commit tagging). --D > thanks, > > greg k-h >
