On Thu, 13 Feb 2025 08:45:43 +0100, Wentao Liang wrote: > > Check the return value of snd_ctl_rename_id() in > snd_hda_create_dig_out_ctls(). Ensure that failures > are properly handled. > > Fixes: 5c219a340850 ("ALSA: hda: Fix kctl->id initialization") > Cc: stable@xxxxxxxxxxxxxxx # 6.4+ > Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx> The error would never happen because this is a rename, and the only error condition of snd_ctl_rename_id() is the lack of the control id. But it's better to have a return check in the caller side, so I took now. Thanks. Takashi