I successfully booted this on the emulator (with some additional patches to our system unrelated to this issue), so Tested-by: Matthew Maurer <mmaurer@xxxxxxxxxx> On Tue, Feb 11, 2025 at 3:10 AM Trevor Gross <tmgross@xxxxxxxxx> wrote: > > On Mon, Feb 10, 2025 at 10:38 AM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote: > > > > Starting with Rust 1.85.0 (to be released 2025-02-20), `rustc` warns > > [1] about disabling neon in the aarch64 hardfloat target: > > > > warning: target feature `neon` cannot be toggled with > > `-Ctarget-feature`: unsound on hard-float targets > > because it changes float ABI > > | > > = note: this was previously accepted by the compiler but > > is being phased out; it will become a hard error > > in a future release! > > = note: for more information, see issue #116344 > > <https://github.com/rust-lang/rust/issues/116344> > > > > Thus, instead, use the softfloat target instead. > > > > While trying it out, I found that the kernel sanitizers were not enabled > > for that built-in target [2]. Upstream Rust agreed to backport > > the enablement for the current beta so that it is ready for > > the 1.85.0 release [3] -- thanks! > > > > However, that still means that before Rust 1.85.0, we cannot switch > > since sanitizers could be in use. Thus conditionally do so. > > > > Cc: <stable@xxxxxxxxxxxxxxx> # Needed in 6.12.y and 6.13.y only (Rust is pinned in older LTSs). > > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > > Cc: Will Deacon <will@xxxxxxxxxx> > > Cc: Matthew Maurer <mmaurer@xxxxxxxxxx> > > Cc: Alice Ryhl <aliceryhl@xxxxxxxxxx> > > Cc: Ralf Jung <post@xxxxxxxx> > > Cc: Jubilee Young <workingjubilee@xxxxxxxxx> > > Link: https://github.com/rust-lang/rust/pull/133417 [1] > > Link: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/arm64.20neon.20.60-Ctarget-feature.60.20warning/near/495358442 [2] > > Link: https://github.com/rust-lang/rust/pull/135905 [3] > > Link: https://github.com/rust-lang/rust/issues/116344 > > Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx> > > This is consistent with what has been discussed for a while on the Rust side. > > Reviewed-by: Trevor Gross <tmgross@xxxxxxxxx>
