On Sun, Feb 09, 2025 at 03:56:11PM +0100, Marek Vasut wrote:
> Add Renesas R-Car D3 USB Download mode quirk and update comments
> on all the other Renesas R-Car USB Download mode quirks to discern
> them from each other. This follows R-Car Series, 3rd Generation
> reference manual Rev.2.00 chapter 19.2.8 USB download mode .
>
> Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> ---
> Cc: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Oliver Neukum <oneukum@xxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> drivers/usb/class/cdc-acm.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 6b37d1c47fce1..06c7d86c5449e 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1727,13 +1727,16 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */
> .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> },
> - { USB_DEVICE(0x045b, 0x023c), /* Renesas USB Download mode */
> + { USB_DEVICE(0x045b, 0x023c), /* Renesas R-Car H3 USB Download mode */
> .driver_info = DISABLE_ECHO, /* Don't echo banner */
> },
> - { USB_DEVICE(0x045b, 0x0248), /* Renesas USB Download mode */
> + { USB_DEVICE(0x045b, 0x0247), /* Renesas R-Car D3 USB Download mode */
> .driver_info = DISABLE_ECHO, /* Don't echo banner */
> },
> - { USB_DEVICE(0x045b, 0x024D), /* Renesas USB Download mode */
> + { USB_DEVICE(0x045b, 0x0248), /* Renesas R-Car M3-N USB Download mode */
> + .driver_info = DISABLE_ECHO, /* Don't echo banner */
> + },
> + { USB_DEVICE(0x045b, 0x024D), /* Renesas R-Car E3 USB Download mode */
> .driver_info = DISABLE_ECHO, /* Don't echo banner */
> },
> { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@xxxxxxxxx */
> --
> 2.47.2
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
