On 05/02/2025 13:44, Greg Kroah-Hartman wrote: > 6.12-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Edward Cree <ecree.xilinx@xxxxxxxxx> > > [ Upstream commit 9e43ad7a1edef268acac603e1975c8f50a20d02f ] > > Ethtool ntuple filters with FLOW_RSS were originally defined as adding > the base queue ID (ring_cookie) to the value from the indirection table, > so that the same table could distribute over more than one set of queues > when used by different filters. > However, some drivers / hardware ignore the ring_cookie, and simply use > the indirection table entries as queue IDs directly. Thus, for drivers > which have not opted in by setting ethtool_ops.cap_rss_rxnfc_adds to > declare that they support the original (addition) semantics, reject in > ethtool_set_rxnfc any filter which combines FLOW_RSS and a nonzero ring. > (For a ring_cookie of zero, both behaviours are equivalent.) > Set the cap bit in sfc, as it is known to support this feature. > > Signed-off-by: Edward Cree <ecree.xilinx@xxxxxxxxx> > Reviewed-by: Martin Habets <habetsm.xilinx@xxxxxxxxx> > Link: https://patch.msgid.link/cc3da0844083b0e301a33092a6299e4042b65221.1731499022.git.ecree.xilinx@xxxxxxxxx > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > Stable-dep-of: 4f5a52adeb1a ("ethtool: Fix set RXNFC command with symmetric RSS hash") > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> If you're taking this you probably also want the very recent 2b91cc1214b1 ("ethtool: ntuple: fix rss + ring_cookie check") which fixes a bug in this patch.
