On Tue, Feb 04, 2025 at 03:20:59PM +0000, Mark Rutland wrote: > The shared hyp swtich header has a number of static functions which > might not be used by all files that include the header, and when unused > they will provoke compiler warnings, e.g. With at least LLVM 18 we still have some issues with unused statics arising from the aliased function definitions: In file included from arch/arm64/kvm/hyp/nvhe/hyp-main.c:8: ./arch/arm64/kvm/hyp/include/hyp/switch.h:699:13: warning: unused function 'kvm_hyp_handle_iabt_low' [-Wunused-function] 699 | static bool kvm_hyp_handle_iabt_low(struct kvm_vcpu *vcpu, u64 *exit_code) | ^~~~~~~~~~~~~~~~~~~~~~~ ./arch/arm64/kvm/hyp/include/hyp/switch.h:701:13: warning: unused function 'kvm_hyp_handle_watchpt_low' [-Wunused-function] 701 | static bool kvm_hyp_handle_watchpt_low(struct kvm_vcpu *vcpu, u64 *exit_code) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ The simplest thing would be to expand the alises into simple wrapper functions but that doesn't feel amazing, I don't know what people's taste is there?
Attachment:
signature.asc
Description: PGP signature