On 30. 01. 25, 21:14, David Laight wrote:
On Thu, 30 Jan 2025 18:43:17 +0000
Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> wrote:
While converting users of msecs_to_jiffies(), lkp reported that some
range checks would always be true because of the mismatch between the
implied int value of secs_to_jiffies() vs the unsigned long
return value of the msecs_to_jiffies() calls it was replacing. Fix this
by casting secs_to_jiffies() values as unsigned long.
Surely 'unsigned long' can't be the right type ?
It changes between 32bit and 64bit systems.
Either it is allowed to wrap - so should be 32bit on both,
or wrapping is unexpected and it needs to be 64bit on both.
But jiffies are really ulong.
--
js
suse labs
