Hi Miquel, > -----Original Message----- > From: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > Sent: Tuesday, 21 January, 2025 5:55 PM > To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx> > Cc: Richard Weinberger <richard@xxxxxx>; Vignesh Raghavendra > <vigneshr@xxxxxx>; linux@xxxxxxxxxxx; Shen Lichuan > <shenlichuan@xxxxxxxx>; Jinjie Ruan <ruanjinjie@xxxxxxxxxx>; u.kleine- > koenig@xxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 3/3] mtd: rawnand: cadence: fix incorrect dev context > in dma_unmap_single > > Hello, > > On 16/01/2025 at 11:21:54 +08, niravkumar.l.rabara@xxxxxxxxx wrote: > > > From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx> > > > > dma_map_single is using dma_dev->dev, however dma_unmap_single is > > using cdns_ctrl->dev, which is incorrect. > > Used the correct device context dma_dev->dev for dma_unmap_single. > > I guess on is the physical/bus device and the other the framework device? It > would be nice to clarify this in the commit log. > Noted. Is the commit message below acceptable? dma_map_single is using physical/bus device (DMA) but dma_unmap_single is using framework device(NAND controller), which is incorrect. Fixed dma_unmap_single to use correct physical/bus device. Thanks, Nirav
