On Thu, 16 Jan 2025 at 15:49, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > Hi! > > I was recently pointed to this driver for an example on how consumers > can get a pointer to the supplier's driver data and I noticed a leak. > > Callers of of_qcom_ice_get() leak the device reference taken by > of_find_device_by_node(). Introduce devm variant for of_qcom_ice_get() > to spare consumers of an extra call to put the dev reference. > > This set touches mmc and scsi subsystems. Since the fix is trivial for > them, I'd suggest taking everything through the SoC tree with Acked-by > tags if people consider this useful. Thanks! Sure! > > Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> # For MMC Kind regards Uffe > --- > Tudor Ambarus (4): > soc: qcom: ice: introduce devm_of_qcom_ice_get > mmc: sdhci-msm: fix dev reference leaked through of_qcom_ice_get > scsi: ufs: qcom: fix dev reference leaked through of_qcom_ice_get > soc: qcom: ice: make of_qcom_ice_get() static > > drivers/mmc/host/sdhci-msm.c | 2 +- > drivers/soc/qcom/ice.c | 37 +++++++++++++++++++++++++++++++++++-- > drivers/ufs/host/ufs-qcom.c | 2 +- > include/soc/qcom/ice.h | 3 ++- > 4 files changed, 39 insertions(+), 5 deletions(-) > --- > base-commit: b323d8e7bc03d27dec646bfdccb7d1a92411f189 > change-id: 20250110-qcom-ice-fix-dev-leak-bbff59a964fb > > Best regards, > -- > Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> >
