Re: [PATCH] block: mark GFP_NOIO around sysfs ->store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 13, 2025 at 08:23:19AM +0000, John Garry wrote:
> On 13/01/2025 01:58, Ming Lei wrote:
> > sysfs ->store is called with queue freezed, meantime we have several
> > ->store() callbacks(update_nr_requests, wbt, scheduler) to allocate
> > memory with GFP_KERNEL which may run into direct reclaim code path,
> > then potential deadlock can be caused.
> > 
> > Fix the issue by marking NOIO around sysfs ->store()
> > 
> > Reported-by: Thomas Hellström<thomas.hellstrom@xxxxxxxxxxxxxxx>
> > Cc:stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Ming Lei<ming.lei@xxxxxxxxxx>
> 
> I guess that you should be including a link to https://lore.kernel.org/linux-block/Z4RkemI9f6N5zoEF@fedora/T/#mc774c65eeca5c024d29695f9ac6152b87763f305
> 

Indeed, I will add a Closes tag in V2.


> Regardless, FWIW:
> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

Thanks,


-- 
Ming





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux