On Mon, Jan 13, 2025 at 09:58:33AM +0800, Ming Lei wrote: > sysfs ->store is called with queue freezed, meantime we have several > ->store() callbacks(update_nr_requests, wbt, scheduler) to allocate > memory with GFP_KERNEL which may run into direct reclaim code path, > then potential deadlock can be caused. > > Fix the issue by marking NOIO around sysfs ->store() Yes, that's a good thing, and we should aim for more of that for block layer code that requires NOIO: Reviewed-by: Christoph Hellwig <hch@xxxxxx>