On Thu, Jan 9, 2025 at 6:08 PM Ignat Korchagin <ignat@xxxxxxxxxxxxxx> wrote: > > On Thu, Jan 9, 2025 at 6:07 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Jan 09, 2025 at 05:39:04PM +0000, Ignat Korchagin wrote: > > > Hi, > > > > > > > On 6 Jan 2025, at 15:14, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > 6.6-stable review patch. If anyone has any objections, please let me know. > > > > > > I think this back port breaks 6.6 build (namely vmlinux.o link stage): > > > LD [M] net/netfilter/xt_nat.ko > > > LD [M] net/netfilter/xt_addrtype.ko > > > LD [M] net/ipv4/netfilter/iptable_nat.ko > > > UPD include/generated/utsversion.h > > > CC init/version-timestamp.o > > > LD .tmp_vmlinux.kallsyms1 > > > ld: vmlinux.o: in function `__crash_kexec': > > > (.text+0x15a93a): undefined reference to `machine_crash_shutdown' > > > ld: vmlinux.o: in function `__do_sys_kexec_file_load': > > > kexec_file.c:(.text+0x15cef1): undefined reference to `arch_kexec_protect_crashkres' > > > ld: kexec_file.c:(.text+0x15cf28): undefined reference to `arch_kexec_unprotect_crashkres' > > > make[2]: *** [scripts/Makefile.vmlinux:37: vmlinux] Error 1 > > > make[1]: *** [/home/ignat/git/test/mainline/linux-6.6.70/Makefile:1164: vmlinux] Error 2 > > > make: *** [Makefile:234: __sub-make] Error 2 > > > > > > The KEXEC config setup, which triggers above: > > > > > > # Kexec and crash features > > > # > > > CONFIG_CRASH_CORE=y > > > CONFIG_KEXEC_CORE=y > > > # CONFIG_KEXEC is not set > > > CONFIG_KEXEC_FILE=y > > > # CONFIG_KEXEC_SIG is not set > > > # CONFIG_CRASH_DUMP is not set > > > # end of Kexec and crash features > > > # end of General setup > > > > Odd, why has no one see this on mainline? Are we missing a change > > somewhere or should this just be reverted for now? > > I actually tested the mainline with this config and it works, so I > think we're missing a change > > Ignat