[AMD Official Use Only - AMD Internal Distribution Only]
> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, January 3, 2025 9:41 AM
> To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx; sashal@xxxxxxxxxx
> Subject: Re: [PATCH] drm/amdgpu: fix backport of commit 73dae652dcac
>
> On Thu, Jan 02, 2025 at 06:08:38PM +0000, Deucher, Alexander wrote:
> > [Public]
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Sent: Friday, December 27, 2024 2:50 AM
> > > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx; sashal@xxxxxxxxxx
> > > Subject: Re: [PATCH] drm/amdgpu: fix backport of commit 73dae652dcac
> > >
> > > On Fri, Dec 27, 2024 at 02:37:00AM -0500, Alex Deucher wrote:
> > > > Commit 73dae652dcac ("drm/amdgpu: rework resume handling for
> > > > display
> > > > (v2)") missed a small code change when it was backported resulting
> > > > in an automatic backlight control breakage. Fix the backport.
> > > >
> > > > Note that this patch is not in Linus' tree as it is not required
> > > > there; the bug was introduced in the backport.
> > > >
> > > > Fixes: 99a02eab8251 ("drm/amdgpu: rework resume handling for
> > > > display
> > > > (v2)")
> > > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3853
> > > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > > > Cc: stable@xxxxxxxxxxxxxxx # 6.11.x
> > >
> > > So the 6.12.y backport is ok? What exact trees is this fix for?
> >
> > Everything older than 6.13 needs this fix. The code changed between 6.12 and
> 6.13 which required a backport of the patch for 6.12 and older kernels. All kernels
> older than 6.13 need this fix. The original backported patch targeted 6.11 and newer
> stable kernels. 6.11 is EOL so probably just 6.12 unless someone pulled the patch
> back to some older kernel as well.
>
> The commit has been backported to the following kernels:
> 5.15.174 6.1.120 6.6.66 6.12.5
> so can you also send proper fixes for 5.15.y, 6.1.y and 6.6.y as well?
Ok. The patch is only needed for 6.11 and newer which is why I specified 6.11 on the original and the fixup. Kernels older than 6.11 didn't support DCN 4.0.1 so it's not applicable. Can we revert the original patch (73dae652dcac ("drm/amdgpu: rework resume handling for display")) from 5.15, 6.1, and 6.6?
Thanks,
Alex
>
> thanks,
>
> greg k-h
