On Mon, Jan 06, 2025 at 10:01:36AM -0800, Jakub Kicinski wrote:
> The NAPI IDs were not fully exposed to user space prior to the netlink
> API, so they were never namespaced. The netlink API must ensure that
> at the very least NAPI instance belongs to the same netns as the owner
> of the genl sock.
>
> napi_by_id() can become static now, but it needs to move because of
> dev_get_by_napi_id().
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 1287c1ae0fc2 ("netdev-genl: Support setting per-NAPI config values")
> Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> Splitting this into fix per-version is a bit tricky, because we need
> to replace the napi_by_id() helper with a better one. I'll send the
> stable versions manually.
>
> CC: jdamato@xxxxxxxxxx
> CC: almasrymina@xxxxxxxxxx
> CC: amritha.nambiar@xxxxxxxxx
> CC: sridhar.samudrala@xxxxxxxxx
> ---
> net/core/dev.c | 43 +++++++++++++++++++++++++++++-------------
> net/core/dev.h | 3 ++-
> net/core/netdev-genl.c | 6 ++----
> 3 files changed, 34 insertions(+), 18 deletions(-)
Thanks.
Reviewed-by: Joe Damato <jdamato@xxxxxxxxxx>
