On Mon, Dec 30, 2024 at 01:30:18PM +0000, Bryan O'Donoghue wrote:
> gdsc_unregister() should release subdomains in the reverse order to the
> order in which those subdomains were added.
>
This sounds very reasonable to me, but what's the actual reason?
> Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support")
> Cc: stable@xxxxxxxxxxxxxxx
Without a reason it's hard to see why this needs to be backported.
Regards,
Bjorn
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> drivers/clk/qcom/gdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index fa5fe4c2a2ee7786c2e8858f3e41301f639e5d59..bc1b1e37bf4222017c172b77603f8dedba961ed5 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -571,7 +571,7 @@ void gdsc_unregister(struct gdsc_desc *desc)
> size_t num = desc->num;
>
> /* Remove subdomains */
> - for (i = 0; i < num; i++) {
> + for (i = num - 1; i >= 0; i--) {
> if (!scs[i])
> continue;
> if (scs[i]->parent)
>
> --
> 2.45.2
>
