5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jordy Zomer <jordyzomer@xxxxxxxxxx> [ Upstream commit 313dab082289e460391c82d855430ec8a28ddf81 ] An offset from client could be a negative value, It could allows to write data outside the bounds of the allocated buffer. Note that this issue is coming when setting 'vfs objects = streams_xattr parameter' in ksmbd.conf. Cc: stable@xxxxxxxxxxxxxxx # v5.15+ Reported-by: Jordy Zomer <jordyzomer@xxxxxxxxxx> Signed-off-by: Jordy Zomer <jordyzomer@xxxxxxxxxx> Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxxx> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> --- fs/ksmbd/smb2pdu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c index 35914c9809aa..0f97830d1ebc 100644 --- a/fs/ksmbd/smb2pdu.c +++ b/fs/ksmbd/smb2pdu.c @@ -6567,6 +6567,8 @@ int smb2_write(struct ksmbd_work *work) } offset = le64_to_cpu(req->Offset); + if (offset < 0) + return -EINVAL; length = le32_to_cpu(req->Length); if (req->Channel == SMB2_CHANNEL_RDMA_V1 || -- 2.39.5
