On Fri, 03 Jan 2025 17:39:39 +0000, Catalin Marinas <catalin.marinas@xxxxxxx> wrote: > > On Fri, Jan 03, 2025 at 05:20:05PM +0000, Catalin Marinas wrote: > > On Fri, Jan 03, 2025 at 02:26:35PM +0000, Marc Zyngier wrote: > > > @@ -3022,6 +3027,13 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > > > .matches = match, \ > > > } > > > > > > +#define HWCAP_CAP_MATCH_ID(match, reg, field, min_value, cap_type, cap) \ > > > + { \ > > > + __HWCAP_CAP(#cap, cap_type, cap) \ > > > + HWCAP_CPUID_MATCH(reg, field, min_value) \ > > > + .matches = match, \ > > > + } > > > > Do we actually need this macro? > > Ignore me, we still need this macro as HWCAP_CAP_MATCH does not take all > the arguments. Maybe not the read_scoped_sysreg() change though. Ah, I just replied to your earlier email. Agreed on avoiding the read_scoped_sysreg() change, replacing it with system_supports_sve(). I'll respin the change now. M. -- Without deviation from the norm, progress is not possible.