> Wouldn't synchronize_rcu() be enough, have you checked? I based usage of synchronize_net() instead of synchronize_rcu() based on other drivers deciding to use it due to synchronize_rcu_expedited() when holding rtnl_lock() being more performant. ICE: https://lore.kernel.org/all/20240529112337.3639084-4-maciej.fijalkowski@xxxxxxxxx/ Mellanox: https://lore.kernel.org/netdev/20210212025641.323844-8-saeed@xxxxxxxxxx/ > You need to use xdp_features_{set,clear}_redirect_target() when you install/remove XDP prog to notify the kernel that ndo_start_xmit is now available / not available anymore. Thank you for the suggestion. Given that the fix has gone in, I was planning to make this change as part of a future net-next release with other XDP changes. Would it make sense to make those changes there, given that the patches as they went up, while not completely correct, should at least cover the vulnerability? Thanks, Josh
