> -----原始邮件----- > 发件人: "Sasha Levin" <sashal@xxxxxxxxxx> > 发送时间:2024-12-30 11:18:48 (星期一) > 收件人: "Binbin Zhou" <zhoubinbin@xxxxxxxxxxx> > 抄送: stable@xxxxxxxxxxxxxxx, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>, "Vinod Koul" <vkoul@xxxxxxxxxx> > 主题: Re: [PATCH 6.12.y] dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL > > On Mon, Dec 30, 2024 at 09:39:19AM +0800, Binbin Zhou wrote: > >Fix the following smatch static checker warning: > > > >drivers/dma/loongson2-apb-dma.c:189 ls2x_dma_write_cmd() > >warn: was expecting a 64 bit value instead of '~(((0)) + (((~((0))) - (((1)) << (0)) + 1) & (~((0)) >> ((8 * 4) - 1 - (4)))))' > > > >The GENMASK macro used "unsigned long", which caused build issues when > >using a 32-bit toolchain because it would try to access bits > 31. This > >patch switches GENMASK to GENMASK_ULL, which uses "unsigned long long". > > > >Fixes: 71e7d3cb6e55 ("dmaengine: ls2x-apb: New driver for the Loongson LS2X APB DMA controller") > >Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > >Closes: https://lore.kernel.org/all/87cdc025-7246-4548-85ca-3d36fdc2be2d@stanley.mountain/ > >Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > >Link: https://lore.kernel.org/r/20241028093413.1145820-1-zhoubinbin@xxxxxxxxxxx > >Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > >(cherry picked from commit 4b65d5322e1d8994acfdb9b867aa00bdb30d177b) > > I'll queue it up, but please read > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-3 > Hi Sasha: Thanks for the heads up. I apologize for my irregularity, although this is the first time I've submitted a patch to stable tree. And I will read the documentation about this part carefully. Thanks. Binbin > -- > Thanks, > Sasha 本邮件及其附件含有龙芯中科的商业秘密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制或散发)本邮件及其附件中的信息。如果您错收本邮件,请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.