Hi Jakub, Thank you for the review! On 20/12/2024 20:56, Jakub Kicinski wrote: > On Fri, 20 Dec 2024 11:54:06 -0800 Jakub Kicinski wrote: >> On Thu, 19 Dec 2024 12:45:26 +0100 Matthieu Baerts (NGI0) wrote: >>> When looking at the MPTCP PM Netlink specs rendered version [1], a few >>> small issues have been found with the descriptions, and fixed here: >>> >>> - Patch 1: add a missing attribute for two events. For >= v5.19. >>> >>> - Patch 2: clearly mention the attributes. For >= v6.7. >>> >>> - Patch 3: fix missing descriptions and replace a wrong one. For >= v6.7. >> >> I'm going to treat this as documentation fixes, so perfectly fine for >> net but they don't need Fixes tags. Hope that's okay, and that I'm >> not missing anything. > > Ah, these also need a regen since the kdoc has changed! > > please run ./tools/net/ynl/ynl-regen.sh Oh, sorry, I didn't know. I will fix that in a v2 without the Fixes and cc stable. Cheers, Matt -- Sponsored by the NGI0 Core fund.