Re: [PATCH 1/3] ring-buffer: Add uname to match criteria for persistent ring buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Dec 2024 14:07:50 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 17 Dec 2024 11:03:28 -0800
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Tue, 17 Dec 2024 at 10:42, Linus Torvalds
> > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:  
> > >
> > > My initial suggestion was to just fix up the boot time array.
> > >
> > > I think that's actually wrong. Just print the raw data and analyze it
> > > in user space.    
> > 
> > .. I still think it's not the optimal solution, but fixing up the
> > event data from the previous boot (*before* printing it, and entirely
> > independently of vsnprintf()) would at least avoid the whole "mess
> > with vsnprintf and switch the format string around as you are trying
> > to walk the va_list in sync".

And that code that does the va_list and vsnprintf() tricks is going to be
removed as soon as that patch set finishes going through my full test suite,
and you are OK with the solution.

Again, that patch set is here:

  https://lore.kernel.org/linux-trace-kernel/20241217024118.587584221@xxxxxxxxxxx/

-- Steve




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux