On Tue, Dec 17, 2024 at 03:55:38PM +0800, Ma Ke wrote: > The reference count of the device incremented in device_initialize() is > not decremented when device_add() fails. Add a put_device() call before > returning from the function to decrement reference count for cleanup. > Or it could cause memory leak. That is not what you did here. Please be more careful when sending out "bugfixes" like this. thanks, greg k-h