The patch titled Subject: drivers/rtc/rtc-s3c.c: Add .needs_src_clk to s3c6410 RTC data has been added to the -mm tree. Its filename is drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> Subject: drivers/rtc/rtc-s3c.c: Add .needs_src_clk to s3c6410 RTC data Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC") added an "rtc_src" DT property to specify the clock used as a source to the S3C real-time clock. Not all SoCs needs this so commit eaf3a659086e ("drivers/rtc/rtc-s3c.c: fix initialization failure without rtc source clock") changed to check the struct s3c_rtc_data .needs_src_clk to conditionally grab the clock. But that commit didn't update the data for each IP version so the RTC broke on the boards that needs a source clock. This is the case of at least Exynos5250 and Exynos5440 which uses the s3c6410 RTC IP block. This commit fixes the S3C rtc on the Exynos5250 Snow and Exynos5420 Peach Pit and Pi Chromebooks. Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> Cc: Doug Anderson <dianders@xxxxxxxxxxxx> Cc: Olof Johansson <olof@xxxxxxxxx> Cc: Kevin Hilman <khilman@xxxxxxxxxx> Cc: Tyler Baker <tyler.baker@xxxxxxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-s3c.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/rtc/rtc-s3c.c~drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data drivers/rtc/rtc-s3c.c --- a/drivers/rtc/rtc-s3c.c~drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data +++ a/drivers/rtc/rtc-s3c.c @@ -849,6 +849,7 @@ static struct s3c_rtc_data const s3c2443 static struct s3c_rtc_data const s3c6410_rtc_data = { .max_user_freq = 32768, + .needs_src_clk = true, .irq_handler = s3c6410_rtc_irq, .set_freq = s3c6410_rtc_setfreq, .enable_tick = s3c6410_rtc_enable_tick, _ Patches currently in -mm which might be from javier.martinez@xxxxxxxxxxxxxxx are drivers-rtc-rtc-s3cc-add-needs_src_clk-to-s3c6410-rtc-data.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html