Re: [PATCH 6.1] leds: an30259a: Use devm_mutex_init() for mutex initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2024 at 11:52:06AM +0800, bin.lan.cn@xxxxxxxxxxxxxxxxx wrote:
> From: George Stark <gnstark@xxxxxxxxxxxxxxxxx>
> 
> [ Upstream commit c382e2e3eccb6b7ca8c7aff5092c1668428e7de6 ]
> 
> In this driver LEDs are registered using devm_led_classdev_register()
> so they are automatically unregistered after module's remove() is done.
> led_classdev_unregister() calls module's led_set_brightness() to turn off
> the LEDs and that callback uses mutex which was destroyed already
> in module's remove() so use devm API instead.
> 
> Signed-off-by: George Stark <gnstark@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20240411161032.609544-9-gnstark@xxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
> [ Resolve merge conflict in drivers/leds/leds-an30259a.c ]
> Signed-off-by: Bin Lan <bin.lan.cn@xxxxxxxxxxxxx>
> ---
>  drivers/leds/leds-an30259a.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)


Now deleted, please see:
        https://lore.kernel.org/r/2024121322-conjuror-gap-b542@gregkh
for what you all need to do, TOGETHER, to get this fixed and so that I
can accept patches from your company in the future.

thanks,

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux