On Wed, Dec 11, 2024 at 10:26:12AM +0800, Ma Ke wrote: > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c > index 77a36e7bddd5..82405c07be3e 100644 > --- a/drivers/ptp/ptp_clock.c > +++ b/drivers/ptp/ptp_clock.c > @@ -348,7 +348,9 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, > ptp->dev.groups = ptp->pin_attr_groups; > ptp->dev.release = ptp_clock_release; > dev_set_drvdata(&ptp->dev, ptp); > - dev_set_name(&ptp->dev, "ptp%d", ptp->index); > + err = dev_set_name(&ptp->dev, "ptp%d", ptp->index); > + if (err) > + goto no_pps; NAK This fails to clean up by calling pps_unregister_source() on the error path. Thanks, Richard
