On Mon, Nov 25, 2024 at 08:55:19AM +0000, John Garry wrote:
On 24/11/2024 12:38, Sasha Levin wrote:
From: John Garry<john.g.garry@xxxxxxxxxx>
[ Upstream commit b1a7ad8b5c4fa28325ee7b369a2d545d3e16ccde ]
Add proper bio_split() error handling. For any error, call
raid_end_bio_io() and return.
For the case of an in the write path, we need to undo the increment in
the rdev pending count and NULLify the r1_bio->bios[] pointers.
For read path failure, we need to undo rdev pending count increment from
the earlier read_balance() call.
Reviewed-by: Yu Kuai<yukuai3@xxxxxxxxxx>
Reviewed-by: Hannes Reinecke<hare@xxxxxxx>
Signed-off-by: John Garry<john.g.garry@xxxxxxxxxx>
Link:https://urldefense.com/v3/__https://lore.kernel.org/ r/20241111112150.3756529-6-john.g.garry@oracle.com__;!!ACWV5N9M2RV99hQ!
N4dieLgwxARnrFj9y51O80wHlzi_DtX0LRE-
kw6X6c0oWji1y3NBy1HIbHaHEkfRZJ57mxEq0kY_YRAnPg$ Signed-off-by: Jens
Axboe<axboe@xxxxxxxxx>
Signed-off-by: Sasha Levin<sashal@xxxxxxxxxx>
I don't think that it is proper to backport this change without
bio_split() error handling update. And I don't think that it is worth
backporting the bio_split() error handling update.
I'll drop it, thanks!
--
Thanks,
Sasha
