On 03. 12. 24, 15:41, Greg Kroah-Hartman wrote:
6.12-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicolin Chen <nicolinc@xxxxxxxxxx>
[ Upstream commit 89edbe88db2857880b08ce363a2695eec657f51b ]
Fix a sparse warning.
Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202410172003.bRQEReTc-lkp@xxxxxxxxx/
Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx>
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20241021230847.811218-1-nicolinc@xxxxxxxxxx
Signed-off-by: Will Deacon <will@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c
index fcd13d301fff6..a243c543598ce 100644
--- a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c
+++ b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c
@@ -800,7 +800,7 @@ static int tegra241_cmdqv_init_structures(struct arm_smmu_device *smmu)
return 0;
}
-struct dentry *cmdqv_debugfs_dir;
+static struct dentry *cmdqv_debugfs_dir;
So now, with
# CONFIG_IOMMU_DEBUGFS is not set
I see:
../drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:804:23: warning:
‘cmdqv_debugfs_dir’ defined but not used [-Wunused-variable]
Should the definition be guarded by CONFIG_IOMMU_DEBUGFS?
/me looks
Ah, yes:
commit 5492f0c4085a8fb8820ff974f17b83a7d6dab5a5
Author: Will Deacon <will@xxxxxxxxxx>
Date: Tue Oct 29 15:58:24 2024 +0000
iommu/tegra241-cmdqv: Fix unused variable warning
Could you pick that up for the next stable?
thanks,
--
js
suse labs
