On Wed, Dec 4, 2024 at 3:30 PM Sasha Levin <sashal@xxxxxxxxxx> wrote: > > From: Saravana Kannan <saravanak@xxxxxxxxxx> > > [ Upstream commit 74ffe43bad3af3e2a786ca017c205555ba87ebad ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 > > Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx> > Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@xxxxxxxxxx/ > Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx> > Suggested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > Acked-by: Thierry Reding <treding@xxxxxxxxxx> > Link: https://lore.kernel.org/r/20241024061347.1771063-3-saravanak@xxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> As mentioned in the original cover letter: PSA: Do not pull any of these patches into stable kernels. fw_devlink had a lot of changes that landed in the last year. It's hard to ensure cherry-picks have picked up all the dependencies correctly. If any of these really need to get cherry-picked into stable kernels, cc me and wait for my explicit Ack. Is there a pressing need for this in 4.19? -Saravana > --- > drivers/phy/tegra/xusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c > index bf7706bf101a6..9a204f78f55db 100644 > --- a/drivers/phy/tegra/xusb.c > +++ b/drivers/phy/tegra/xusb.c > @@ -537,7 +537,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, > > device_initialize(&port->dev); > port->dev.type = &tegra_xusb_port_type; > - port->dev.of_node = of_node_get(np); > + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); > port->dev.parent = padctl->dev; > > err = dev_set_name(&port->dev, "%s-%u", name, index); > -- > 2.43.0 >
