Re: [tpmdd-devel] [PATCH] Added Little Endian support to vtpm module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vicky

tldr: I applied your patch manually.

Am Freitag, 13. Februar 2015, 03:02:24 schrieb honclo:
> The tpm_ibmvtpm module is affected by an unaligned access problem.
> ibmvtpm_crq_get_version failed with rc=-4 during boot when vTPM is
> enabled in Power partition, which supports both little endian and
> big endian modes.
> 
> We added little endian support to fix this problem:
> 1) added cpu_to_be64 calls to ensure BE data is sent from an LE OS.
> 2) added be16_to_cpu and be32_to_cpu calls to make sure data received
>    is in LE format on a LE OS.
> 
> Signed-off-by: Hon Ching(Vicky) Lo <honclo@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Joy Latten <jmlatten@xxxxxxxxxxxxxxxxxx>
> ---
>   drivers/char/tpm/tpm_ibmvtpm.c |   20 ++++++++++++--------
>   1 files changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
> b/drivers/char/tpm/tpm_ibmvtpm.c
> index af74c57..1632242 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -148,7 +148,8 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip,
> u8 *buf, size_t count)


For whatever reason neither git nor patch was able to cope with your patch 
directly :(
Also Patchwork has its problems:
 https://patchwork.ozlabs.org/patch/439361/
it only shows the last hunk.

It seems that your mail client splits long lines automatically :(
Did you send it via git-send-email?

In 'my' version of the patch 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
> b/drivers/char/tpm/tpm_ibmvtpm.c
is only one line.


I did apply it manually now.

https://github.com/PeterHuewe/linux-tpmdd/commit/eb71f8a5e33fa1066fb92f0111ab366a341e1f6c

>-- 
>1.7.1
Maybe update your git version?



Also can you please set your reply-to emailadress correctly?
 honclo <honclo@xxxxxxxxxxxxxxxxxx>
does not work.



Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]