Re: [PATCH 6.1] gve: Fixes for napi_poll when budget is 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 26, 2024 at 06:47:31PM +0000, Ziwei Xiao wrote:
> Netpoll will explicitly pass the polling call with a budget of 0 to
> indicate it's clearing the Tx path only. For the gve_rx_poll and
> gve_xdp_poll, they were mistakenly taking the 0 budget as the indication
> to do all the work. Add check to avoid the rx path and xdp path being
> called when budget is 0. And also avoid napi_complete_done being called
> when budget is 0 for netpoll.
> 
> The original fix was merged here:
> https://lore.kernel.org/r/20231114004144.2022268-1-ziweixiao@xxxxxxxxxx
> Resend it since the original one was not cleanly applied to 6.1 kernel.
> 
> Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> Signed-off-by: Ziwei Xiao <ziweixiao@xxxxxxxxxx>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/google/gve/gve_main.c | 7 +++++++
>  drivers/net/ethernet/google/gve/gve_rx.c   | 4 ----
>  drivers/net/ethernet/google/gve/gve_tx.c   | 4 ----
>  3 files changed, 7 insertions(+), 8 deletions(-)
> 

No git id? :(




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux