On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > If the coreutils variant of ping is used instead of the busybox one, the > ping_do() command is broken. This comes by the fact that for coreutils > ping, the ping IP needs to be the very last elements. > > To handle this, reorder the ping args and make $dip last element. > > The use of coreutils ping might be useful for case where busybox is not > compiled with float interval support and ping command doesn't support > 0.1 interval. (in such case a dedicated ping utility is installed > instead) > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 73bae6736b6b ("selftests: forwarding: Add initial testing framework") > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > --- Do you mean the other way around? that the busybox ping is the broken one? And by coreutils ping, you actually mean iputils ping, right?