Re: [PATCH 6.6] drm/amd/display: Add NULL pointer check for kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ Sasha's backport helper bot ]

Hi,

The upstream commit SHA1 provided is correct: 8e65a1b7118acf6af96449e1e66b7adbc9396912

WARNING: Author mismatch between patch and upstream commit:
Backport author: bin.lan.cn@xxxxxxxxxxxxxxxxx
Commit author: Hersen Wu <hersenxs.wu@xxxxxxx>


Status in newer kernel trees:
6.12.y | Present (exact SHA1)
6.11.y | Present (exact SHA1)
6.6.y | Not found

Note: The patch differs from the upstream commit:
---
1:  8e65a1b7118ac ! 1:  a22a302a24281 drm/amd/display: Add NULL pointer check for kzalloc
    @@ Metadata
      ## Commit message ##
         drm/amd/display: Add NULL pointer check for kzalloc
     
    +    [ Upstream commit 8e65a1b7118acf6af96449e1e66b7adbc9396912 ]
    +
         [Why & How]
         Check return pointer of kzalloc before using it.
     
    @@ Commit message
         Acked-by: Wayne Lin <wayne.lin@xxxxxxx>
         Signed-off-by: Hersen Wu <hersenxs.wu@xxxxxxx>
         Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
    +    [ Resolve minor conflicts ]
    +    Signed-off-by: Bin Lan <bin.lan.cn@xxxxxxxxxxxxx>
     
      ## drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c ##
     @@ drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c: void dcn3_clk_mgr_construct(
    @@ drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: void dcn32_clk_mgr
      
      void dcn32_clk_mgr_destroy(struct clk_mgr_internal *clk_mgr)
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c: bool dcn30_validate_bandwidth(struct dc *dc,
    + ## drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c: bool dcn30_validate_bandwidth(struct dc *dc,
      
      	BW_VAL_TRACE_COUNT();
      
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c: bool dcn30_valid
      	out = dcn30_internal_validate_bw(dc, context, pipes, &pipe_cnt, &vlevel, fast_validate, true);
      	DC_FP_END();
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c: static struct hp
      
      	hpo_dp_link_encoder31_construct(hpo_dp_enc31, ctx, inst,
      					&hpo_dp_link_enc_regs[inst],
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c: bool dcn31_validate_bandwidth(struct dc *dc,
    +@@ drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c: bool dcn31_validate_bandwidth(struct dc *dc,
      
      	BW_VAL_TRACE_COUNT();
      
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c: bool dcn31_valid
      	out = dcn30_internal_validate_bw(dc, context, pipes, &pipe_cnt, &vlevel, fast_validate, true);
      	DC_FP_END();
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c: static struct
      
      	hpo_dp_link_encoder31_construct(hpo_dp_enc31, ctx, inst,
      					&hpo_dp_link_enc_regs[inst],
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c: bool dcn314_validate_bandwidth(struct dc *dc,
    +@@ drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c: bool dcn314_validate_bandwidth(struct dc *dc,
      
      	BW_VAL_TRACE_COUNT();
      
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c: bool dcn314_va
      		goto validate_fail;
      
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c: static struct
      	hpo_dp_link_encoder31_construct(hpo_dp_enc31, ctx, inst,
      					&hpo_dp_link_enc_regs[inst],
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c: static struct
      	hpo_dp_link_encoder31_construct(hpo_dp_enc31, ctx, inst,
      					&hpo_dp_link_enc_regs[inst],
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c: static struct hpo_dp_link_encoder *dcn32_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c: static struct hpo_dp_link_encoder *dcn32_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c: static struct hp
      
      #undef REG_STRUCT
      #define REG_STRUCT hpo_dp_link_enc_regs
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c: static bool dml1_validate(struct dc *dc, struct dc_state *context, bool fast_val
    +@@ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c: bool dcn32_validate_bandwidth(struct dc *dc,
      
      	BW_VAL_TRACE_COUNT();
      
    @@ drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c: static bool dml1
      	out = dcn32_internal_validate_bw(dc, context, pipes, &pipe_cnt, &vlevel, fast_validate);
      	DC_FP_END();
     
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c: static struct hpo_dp_link_encoder *dcn321_hpo_dp_link_encoder_create(
    - 
    - 	/* allocate HPO link encoder */
    - 	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    -+	if (!hpo_dp_enc31)
    -+		return NULL; /* out of memory */
    - 
    - #undef REG_STRUCT
    - #define REG_STRUCT hpo_dp_link_enc_regs
    -
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    - 
    - 	/* allocate HPO link encoder */
    - 	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
    -+	if (!hpo_dp_enc31)
    -+		return NULL; /* out of memory */
    - 
    - #undef REG_STRUCT
    - #define REG_STRUCT hpo_dp_link_enc_regs
    -
    - ## drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c ##
    -@@ drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c: static struct hpo_dp_link_encoder *dcn31_hpo_dp_link_encoder_create(
    + ## drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c ##
    +@@ drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c: static struct hpo_dp_link_encoder *dcn321_hpo_dp_link_encoder_create(
      
      	/* allocate HPO link encoder */
      	hpo_dp_enc31 = kzalloc(sizeof(struct dcn31_hpo_dp_link_encoder), GFP_KERNEL);
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y        |  Success    |  Success   |




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux