On Mon, Nov 25, 2024 at 05:29:08PM -0800, Darrick J. Wong wrote: > This is currently not the case anywhere in the filesystem because quota > updates always dirty at least one other metadata item, but a subsequent > bug fix will add dquot log item precommits, so we actually need a dirty > dquot log item prior to xfs_trans_run_precommits. Also let's not leave > a logic bomb. Unlike for the sb updates there doesn't seem to be anything in xfs_trans_mod_dquot that forces the transaction to be dirty, so I guess the fixes tag is fine here. Reviewed-by: Christoph Hellwig <hch@xxxxxx>