On Tue, Nov 19, 2024 at 7:50 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > As per [1] and [2], ADV7535/7533 supports only 2-, 3-, or 4-lane. Drop > unsupported 1-lane. > > [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf > [2] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf Thanks for doing that. I never noticed it only supported 2,3 or 4 lanes, but this patch makes sense to me. > > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > Reported-by: Hien Huynh <hien.huynh.px@xxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx Reviewed-by: Adam Ford <aford173@xxxxxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > Changes in v5: > - No change. > Changes in v4: > - Added link to ADV7533 data sheet. > - Collected tags > Changes in v3: > - Updated commit header and description > - Updated fixes tag > - Dropped single lane support > Changes in v2: > - Added the tag "Cc: stable@xxxxxxxxxxxxxxx" in the sign-off area. > - Dropped Archit Taneja invalid Mail address > --- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c > index 5f195e91b3e6..122ad91e8a32 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c > @@ -172,7 +172,7 @@ int adv7533_parse_dt(struct device_node *np, struct adv7511 *adv) > > of_property_read_u32(np, "adi,dsi-lanes", &num_lanes); > > - if (num_lanes < 1 || num_lanes > 4) > + if (num_lanes < 2 || num_lanes > 4) > return -EINVAL; > > adv->num_dsi_lanes = num_lanes; > -- > 2.43.0 > >
