On Mon, Feb 09, 2015 at 02:15:06PM -0800, David Daney wrote: > On 02/07/2015 05:59 PM, Greg Kroah-Hartman wrote: > >On Sat, Feb 07, 2015 at 05:35:24PM -0800, Guenter Roeck wrote: > >>3.10, 3.14, and 3.18 are affected. > >> > >>Build is still going on, so there may be more problems. > >> > >>Guenter > >> > >>--- > >>All mips builds: > >> > >>arch/mips/mm/tlb-r4k.c: In function 'tlb_init': > >>arch/mips/mm/tlb-r4k.c:448:7: error: 'cpu_has_rixiex' undeclared (first use in this function) > >>arch/mips/mm/tlb-r4k.c:448:7: note: each undeclared identifier is reported only once for each function it appears in > >>arch/mips/mm/tlb-r4k.c:449:10: error: 'PG_IEC' undeclared (first use in this function) > >>make[2]: *** [arch/mips/mm/tlb-r4k.o] Error 1 > >> > >>Caused by 'MIPS: Fix C0_Pagegrain[IEC] support'. > >> > >>This is supposed to affect 3.17+, so not entirely sure I understand why it was > >>applied to 3.10 and 3.14. David may know what needs to change to apply it to 3.18, > >>and if it is needed in 3.10 / 3.14. > > > >Oops, my fault, I missed the "only for 3.17 and greater" type text in > >the body of the changelog. I've now removed it from the queue. > > > > Perhaps I could have made it more clear, but I am glad that it now appears > to be sorted out. Is there a better way to annotate the patches to avoid > this type of misunderstanding in the future? > > If so, I would consider enhancing Documentation/stable_kernel_rules.txt to > make it more clear. that file does say how to do it so I notice it a bit easier: Cc: <stable@xxxxxxxxxxxxxxx> # 3.3.x If you think it could be worded better, I always accept patches to it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html