On (24/11/15 13:07), Jan Kara wrote: > On Fri 15-11-24 15:08:48, Sergey Senozhatsky wrote: > > From: Jan Kara <jack@xxxxxxx> > > > > [ Upstream commit 0aba4860b0d0216a1a300484ff536171894d49d8 ] > > > > Currently we allocate name buffer in directory iterators (struct > > udf_fileident_iter) on stack. These structures are relatively large > > (some 360 bytes on 64-bit architectures). For udf_rename() which needs > > to keep three of these structures in parallel the stack usage becomes > > rather heavy - 1536 bytes in total. Allocate the name buffer in the > > iterator from heap to avoid excessive stack usage. > > > > Link: https://lore.kernel.org/all/202212200558.lK9x1KW0-lkp@xxxxxxxxx > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > [ senozhatsky: explicitly include slab.h to address build > > failure reported by sashal@ ] > > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > > Mauke beat you to this, Greg already queued up his patches :) Story of my life :) > [1] https://lore.kernel.org/all/20241114212657.306989-1-hauke@xxxxxxxxxx Awesome, thanks everyone!
