On 09/02/15 15:35, Greg Kroah-Hartman wrote:
> On Mon, Feb 09, 2015 at 10:10:33AM +0000, James Hogan wrote:
>> Hi Greg,
>>
>> On 09/02/15 08:16, Greg Kroah-Hartman wrote:
>>> On Sun, Feb 08, 2015 at 09:35:29AM -0800, Guenter Roeck wrote:
>>>> All mips builds (3.18 only)
>>>>
>>>> arch/mips/kernel/traps.c: In function 'enable_restore_fp_context':
>>>> arch/mips/kernel/traps.c:1187:4: error: implicit declaration of function 'write_32bit_cp1_register'
>>>> arch/mips/kernel/traps.c:1187:29: error: '$31' undeclared (first use in this function)
>>>>
>>>> Caused by "MIPS: traps: Fix inline asm ctc1 missing .set hardfloat".
>>>>
>>>> You also need 5e32033e14ca9c7 ("MIPS: mipsregs.h: Add write_32bit_cp1_register").
>>>
>>> Thanks, I'll go add that patch.
>>
>> If there's anything I could have done better with the stable Cc tag from
>> your point of view, please let me know.
>>
>> I put this:
>> Cc: <stable@xxxxxxxxxxxxxxx> # 3.18+, depends on "MIPS: mipsregs.h: Add write_32bit_cp1_register()"
>>
>> But without a commit id as I submitted both patches together, and
>> without the stable Cc tag on that other commit as it isn't a bug fix in
>> isolation.
>
> You should have marked the previous commit also with the stable tag as
> you knew it would be needed for the stable trees. I missed it because
> there was no SHA listed in the patch, and the patch was able to be
> applied properly, it's hard for me to search for a patch by a string
> only, as my scripts can not do that at all.
>
> Not a big deal, it's now working, but a heads up from you when you saw
> just the one patch go in would have been good.
Okay, thanks, and sorry about that.
Cheers
James
Attachment:
signature.asc
Description: OpenPGP digital signature