Re: [PATCH 5.4 62/66] mm: clarify a confusing comment for remap_pfn_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

The patch series is fine but I missed one final patch of the patch
series. I'd like to send a v2 if it's possible. The series is missing
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=35770ca6180caa24a2b258c99a87bd437a1ee10f
unfortunately which is the fix itself. These patches were required to
get a clean pick when backporting this patch but I forgot to send the
final patch itself. Sorry for the inconvenience caused.

Thanks & Regards,
Harshvardhan

On 15/11/24 12:08 PM, Greg Kroah-Hartman wrote:
> 5.4-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: WANG Wenhu <wenhu.wang@xxxxxxxx>
>
> commit 86a76331d94c4cfa72fe1831dbe4b492f66fdb81 upstream.
>
> It really made me scratch my head.  Replace the comment with an accurate
> and consistent description.
>
> The parameter pfn actually refers to the page frame number which is
> right-shifted by PAGE_SHIFT from the physical address.
>
> Signed-off-by: WANG Wenhu <wenhu.wang@xxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Link: https://urldefense.com/v3/__http://lkml.kernel.org/r/20200310073955.43415-1-wenhu.wang@vivo.com__;!!ACWV5N9M2RV99hQ!KIWd_kui8J754PtgbyIkIgs5FO5lVNz7kLCkgbvI2fyaF0L12Y-unOmAYPsYWyr-RMIYHLBN4M2PzFgU9jvCBTKGJyg15w$ 
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Harshvardhan Jha <harshvardhan.j.jha@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  mm/memory.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1921,7 +1921,7 @@ static inline int remap_p4d_range(struct
>   * remap_pfn_range - remap kernel memory to userspace
>   * @vma: user vma to map to
>   * @addr: target user address to start at
> - * @pfn: physical address of kernel memory
> + * @pfn: page frame number of kernel physical memory address
>   * @size: size of map area
>   * @prot: page protection flags for this mapping
>   *
>
>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux