On Thu, Nov 14, 2024 at 05:31:07PM +0800, Bin Lan wrote: > From: Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx> > > [ Upstream commit a33fb016e49e37aafab18dc3c8314d6399cb4727 ] > > Fixed deleating of a non-resident attribute in ntfs_create_inode() > rollback. > > Reported-by: syzbot+9af29acd8f27fbce94bc@xxxxxxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Bin Lan <bin.lan.cn@xxxxxxxxxxxxx> > --- > fs/ntfs3/inode.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c > index 026ed43c0670..8d1cfa0fc13f 100644 > --- a/fs/ntfs3/inode.c > +++ b/fs/ntfs3/inode.c > @@ -1646,6 +1646,15 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns, > le16_to_cpu(new_de->key_size), sbi); > /* ni_unlock(dir_ni); will be called later. */ > out6: > + attr = ni_find_attr(ni, NULL, NULL, ATTR_EA, NULL, 0, NULL, NULL); > + if (attr && attr->non_res) { > + /* Delete ATTR_EA, if non-resident. */ > + struct runs_tree run; > + run_init(&run); > + attr_set_size(ni, ATTR_EA, NULL, 0, &run, 0, NULL, false, NULL); > + run_close(&run); > + } > + You have trailing whitespace here :(