On Wed, Nov 13, 2024 at 11:05:13AM -0500, Josef Bacik wrote:
> When I reworked delayed ref comparison in cf4f04325b2b ("btrfs: move
> ->parent and ->ref_root into btrfs_delayed_ref_node"), I made a mistake
> and returned -1 for the case where ref1->ref_root was > than
> ref2->ref_root. This is a subtle bug that can result in improper
> delayed ref running order, which can result in transaction aborts.
>
> cc: stable@xxxxxxxxxxxxxxx
> Fixes: cf4f04325b2b ("btrfs: move ->parent and ->ref_root into btrfs_delayed_ref_node")
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
Simple and serious fix, I'll send a pull request today. Thanks.
