Re: [PATCH v2 1/1] ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/2024 13:12, Greg KH wrote:
On Tue, Nov 12, 2024 at 01:01:54PM +0100, Agathe Porte wrote:
These two fields are populated during and stored as a "frequently used
value" in ufs_fill_super, but are not used afterwards in the driver.

Moreover, one of the shifts triggers UBSAN: shift-out-of-bounds when
apbshift is 12 because 12 * 3 = 36 and 1 << 36 does not fit in the 32
bit integer used to store the value.

Cc: stable@xxxxxxxxxxxxxxx
Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087853
As these values are not used, even if the shift goes off in the wild
it's not needed to backport this as it's not actually causing any
problems.  So I'd drop the cc: stable@ please.

OK, sent a v3 that drops the stable cc: https://lore.kernel.org/linux-kernel/20241112122000.35610-1-agathe.porte@xxxxxxxxxxxxx/T/#t





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux