Re: [PATCH 4/5] scsi: ufs: pltfrm: Drop PM runtime reference count after ufshcd_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-11-11 at 23:18 +0530, Manivannan Sadhasivam via B4 Relay
wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> 
> During the remove stage of glue drivers, some of them are
> incrementing the
> reference count using pm_runtime_get_sync(), before removing the
> ufshcd
> using ufshcd_remove(). But they are not dropping that reference count
> after
> ufshcd_remove() to balance the refcount.
> 
> So drop the reference count by calling pm_runtime_put_noidle() after
> ufshcd_remove(). Since the behavior is applicable to all glue
> drivers, move
> the PM handling to ufshcd_pltfrm_remove().
> 
> Cc: stable@xxxxxxxxxxxxxxx # 3.12
> Fixes: 62694735ca95 ("[SCSI] ufs: Add runtime PM support for UFS host
> controller driver")
> Signed-off-by: Manivannan Sadhasivam <
> manivannan.sadhasivam@xxxxxxxxxx>
> ---
>  drivers/ufs/host/tc-dwc-g210-pltfrm.c | 1 -
>  drivers/ufs/host/ufs-exynos.c         | 1 -
>  drivers/ufs/host/ufs-mediatek.c       | 1 -
>  drivers/ufs/host/ufs-qcom.c           | 1 -
>  drivers/ufs/host/ufs-sprd.c           | 1 -
>  drivers/ufs/host/ufshcd-pltfrm.c      | 2 ++
>  6 files changed, 2 insertions(+), 5 deletions(-)
> 
> 

Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux