> -----邮件原件-----
> 发件人: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> 发送时间: 2024年11月9日 14:59
> 收件人: Rex Nie <rex.nie@xxxxxxxxxxxxxxx>
> 抄送: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Angus Chen
> <angus.chen@xxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
> 主题: Re: [PATCH v2] USB: core: remove dead code in do_proc_bulk()
>
> External Mail: This email originated from OUTSIDE of the organization!
> Do not click links, open attachments or provide ANY information unless you
> recognize the sender and know the content is safe.
>
>
> On Sat, Nov 09, 2024 at 10:11:41AM +0800, Rex Nie wrote:
> > Since len1 is unsigned int, len1 < 0 always false. Remove it keep code
> > simple.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: ae8709b296d8 ("USB: core: Make do_proc_control() and
> > do_proc_bulk() killable")
> > Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx>
> > ---
> > changes in v2:
> > - Add "Cc: stable@xxxxxxxxxxxxxxx" (kernel test robot)
>
> Why is this relevant for the stable kernels? What bug is being fixed that
> users would hit that this is needed to resolve?
HI Greg k-h, I got a email from lkp@xxxxxxxxx let me add Cc tag yesterday, so I apply v2 patch.
Although this shouldn't bother users, the expression len1 < 0 in the if condition doesn't make sense,
and removing it makes the code more simple and efficient. The original email from kernel robot test
shows as follows. I think it no need a cc tag either.
Thanks
Rex
---
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
Rule: add the tag "Cc: stable@xxxxxxxxxxxxxxx" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH] USB: core: remove dead code in do_proc_bulk()
Link: https://lore.kernel.org/stable/20241108094255.2133-1-rex.nie%40jaguarmicro.com
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
---
> thanks,
>
> greg k-h
