RE: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thanks for the feedback.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Sent: 06 November 2024 19:31
> Subject: Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Wed, Nov 06, 2024 at 06:49:29PM +0000, Biju Das wrote:
> > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop
> > unsupported 1-lane from bindings.
> >
> > [1]
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD
> > V7535.pdf
> 
> No need for a line break, you can write
> 
> [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf

Agreed. Will add the missing link for ADV7533 as well.

Cheers,
Biju

> 
> >
> > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> 
> > ---
> > v3:
> >  * New patch.
> > ---
> >  .../devicetree/bindings/display/bridge/adi,adv7533.yaml         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> > b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> > index df20a3c9c744..ec89115c74e4 100644
> > ---
> > a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yam
> > +++ l
> > @@ -90,7 +90,7 @@ properties:
> >    adi,dsi-lanes:
> >      description: Number of DSI data lanes connected to the DSI host.
> >      $ref: /schemas/types.yaml#/definitions/uint32
> > -    enum: [ 1, 2, 3, 4 ]
> > +    enum: [ 2, 3, 4 ]
> >
> >    "#sound-dai-cells":
> >      const: 0
> 
> --
> Regards,
> 
> Laurent Pinchart




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux