Re: [PATCH] wacom: Interpret tilt data from Intuos Pro BT as signed values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 Oct 2024, Gerecke, Jason wrote:

> From: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> 
> The tilt data contained in the Bluetooth packets of an Intuos Pro are
> supposed to be interpreted as signed values. Simply casting the values
> to type `char` is not guaranteed to work since it is implementation-
> defined whether it is signed or unsigned. At least one user has noticed
> the data being reported incorrectly on their system. To ensure that the
> data is interpreted properly, we specifically cast to `signed char`
> instead.
> 
> Link: https://github.com/linuxwacom/input-wacom/issues/445
> Fixes: 4922cd26f03c ("HID: wacom: Support 2nd-gen Intuos Pro's Bluetooth classic interface")
> CC: stable@xxxxxxxxxxxxxxx # 4.11+
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>

I have added 'HID: ' prefix to the subject line and applied, thanks.

-- 
Jiri Kosina
SUSE Labs





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux